xfs
[Top] [All Lists]

Re: [dm-devel] [PATCH 02/35] block: add REQ_OP definitions and bi_op/op

To: device-mapper development <dm-devel@xxxxxxxxxx>, mchristi@xxxxxxxxxx
Subject: Re: [dm-devel] [PATCH 02/35] block: add REQ_OP definitions and bi_op/op fields
From: Mike Christie <michaelc@xxxxxxxxxxx>
Date: Sat, 09 Jan 2016 18:56:14 -0600
Cc: linux-bcache@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, konrad.wilk@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, philipp.reisner@xxxxxxxxxx, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, osd-dev@xxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, lars.ellenberg@xxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160109133716.GB26660@xxxxxxxxxxxxx>
References: <1452027218-32303-1-git-send-email-mchristi@xxxxxxxxxx> <1452027218-32303-3-git-send-email-mchristi@xxxxxxxxxx> <20160109133716.GB26660@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
On 01/09/2016 07:37 AM, Christoph Hellwig wrote:
> Seems like this is missing REQ_OP_FLUSH, which still hides as a write?
> 

I might have misunderstood what you wanted or am misunderstanding you now.

I did not change the flush related code until the last patches. I added
REQ_OP_FLUSH in patch:

[PATCH 33/35] block, drivers: add REQ_OP_FLUSH operation
commit 18dea20363ba245a47bc1bb54f6465b8a05b19af
Author: Mike Christie <mchristi@xxxxxxxxxx>
Date:   Tue Jan 5 21:02:17 2016 -0600

    block, drivers: add REQ_OP_FLUSH operation


and I added the REQ_PREFLUSH flag in


[PATCH 35/35] block, drivers, fs: rename REQ_FLUSH to REQ_PREFLUSH
commit 303dc6a7cc3673065538ba041562fcd833a619af
Author: Mike Christie <mchristi@xxxxxxxxxx>
Date:   Thu Jan 7 18:17:03 2016 -0600

    block, drivers, fs: rename REQ_FLUSH to REQ_PREFLUSH


I did them in separate patches, because I was not sure if they were
correct with what you requested before, and because they were a little
more tricky because of how request_fn drivers, make_request_fn drivers,
and dm-multipath handle flushes differently.

<Prev in Thread] Current Thread [Next in Thread>