xfs
[Top] [All Lists]

Re: [PATCH 01/35] block/fs/drivers: remove rw argument from submit_bio

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>, mchristi@xxxxxxxxxx
Subject: Re: [PATCH 01/35] block/fs/drivers: remove rw argument from submit_bio
From: Mike Christie <michaelc@xxxxxxxxxxx>
Date: Sat, 09 Jan 2016 18:43:32 -0600
Cc: linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, konrad.wilk@xxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, philipp.reisner@xxxxxxxxxx, lars.ellenberg@xxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, osd-dev@xxxxxxxxxxxx, xfs@xxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160109133409.GA26660@xxxxxxxxxxxxx>
References: <1452027218-32303-1-git-send-email-mchristi@xxxxxxxxxx> <1452027218-32303-2-git-send-email-mchristi@xxxxxxxxxx> <20160109133409.GA26660@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
On 01/09/2016 07:34 AM, Christoph Hellwig wrote:
>>                              count);
>> > diff --git a/block/blk-flush.c b/block/blk-flush.c
>> > index 9c423e5..e092e13 100644
>> > --- a/block/blk-flush.c
>> > +++ b/block/blk-flush.c
>> > @@ -484,8 +484,9 @@ int blkdev_issue_flush(struct block_device *bdev, 
>> > gfp_t gfp_mask,
>> >  
>> >    bio = bio_alloc(gfp_mask, 0);
>> >    bio->bi_bdev = bdev;
>> > +  bio->bi_rw |= WRITE_FLUSH;
> Shouldn't the |= be a = here and in many other places?

Yeah, I was trying to merge bi_rw and bio_flags. I am not going to send
that. I will fix up the patchset.

<Prev in Thread] Current Thread [Next in Thread>