xfs
[Top] [All Lists]

Re: [PATCH 34/76] xfs: implement XFS_IOC_SWAPEXT when rmap btree is enab

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 34/76] xfs: implement XFS_IOC_SWAPEXT when rmap btree is enabled
From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Date: Wed, 6 Jan 2016 16:09:39 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160105024130.GI19802@dastard>
References: <20151219085622.12713.88678.stgit@xxxxxxxxxxxxxxxx> <20151219090008.12713.25755.stgit@xxxxxxxxxxxxxxxx> <20160103121728.GC28429@xxxxxxxxxxxxx> <20160104234033.GD28330@xxxxxxxxxxxxxxxx> <20160105024130.GI19802@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jan 05, 2016 at 01:41:30PM +1100, Dave Chinner wrote:
> On Mon, Jan 04, 2016 at 03:40:33PM -0800, Darrick J. Wong wrote:
> > On Sun, Jan 03, 2016 at 04:17:28AM -0800, Christoph Hellwig wrote:
> > > On Sat, Dec 19, 2015 at 01:00:08AM -0800, Darrick J. Wong wrote:
> > > > Implement extent swapping when reverse-mapping is enabled.
> > > 
> > > Can you just fold this into the previous patch?  There seem to be a lot
> > > of patches in the series that would benefit from merging, but this
> > > is the one that really screams for it :)
> > 
> > The only reason I'm keeping Dave's original rmap patches separate is because
> > the last time I checked with Dave, he said that he'd made a few bugfixes to 
> > his
> > patchset that hadn't yet been sent out, so I'd like to merge those fixes 
> > into
> > the original patches before starting any combining work.
> 
> I haven't had a chance to sort any of those out fully, so it's
> probably best if you combine all your patches to minimise the
> separation and I'll send delta patches (if still relevant) as I work
> through it all in the next couple of weeks...

Ok, I'll start combining them as I remove all the kerneldoc comments.  I think
I've gotten all the "CoW reservations left over at unmount" bugs out, so I'll
probably have a slimmer patchset in a week or two.

(Or everything will go nuts on some weird arch like arm64 and kablooie...)

--D

> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>