xfs
[Top] [All Lists]

Re: [PATCH 3/3] xfs: cancel COW in xfs_cancel_ioend

To: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject: Re: [PATCH 3/3] xfs: cancel COW in xfs_cancel_ioend
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 5 Jan 2016 02:42:14 -0800
Cc: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160105014310.GK28330@xxxxxxxxxxxxxxxx>
References: <1451822873-12969-1-git-send-email-hch@xxxxxx> <1451822873-12969-4-git-send-email-hch@xxxxxx> <20160105014310.GK28330@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Mon, Jan 04, 2016 at 05:43:10PM -0800, Darrick J. Wong wrote:
> Hmm.  This might be the cause of the occasional complaints I've been seeing
> where allocated blocks remain in the COW fork when the inode is being cleared
> out.  That said, the xfs_reflink_end_cow_failed() is apparently missing a
> xfs_bunmapi_cow() to actually clean out the COW fork.

I can still reproduce xfs_reflink_cancel_pending_cow tripping over
allocated blocks in the COW fork over NFS.  generic/154 reproduces
it 100% over NFS, although when adding a delay before the cleanup
it disappears.  I'm currently trying to figure out why.

<Prev in Thread] Current Thread [Next in Thread>