| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 35/76] libxfs: refactor short btree block verification |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 4 Jan 2016 08:30:38 +1100 |
| Cc: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20160103121832.GD28429@xxxxxxxxxxxxx> |
| References: | <20151219085622.12713.88678.stgit@xxxxxxxxxxxxxxxx> <20151219090014.12713.75657.stgit@xxxxxxxxxxxxxxxx> <20160103121832.GD28429@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Sun, Jan 03, 2016 at 04:18:32AM -0800, Christoph Hellwig wrote: > > +/** > > + * xfs_btree_sblock_v5hdr_verify() -- verify the v5 fields of a > > short-format > > + * btree block > > + * > > + * @bp: buffer containing the btree block > > + * @max_recs: pointer to the m_*_mxr max records field in the xfs mount > > + * @pag_max_level: pointer to the per-ag max level field > > + */ > > We're so far avoided using kerneldoc comments and they silly super > verbosity in XFS. It might be good to tone this down to the normal > XFS level (same for some other patches). I'll do that before I commit it. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 02/76] xfs: fix log ticket type printing, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH V2] xfs: create helper for bmap finish & trans join in attr code, Dave Chinner |
| Previous by Thread: | Re: [PATCH 35/76] libxfs: refactor short btree block verification, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 57/76] xfs: allocate delayed extents in CoW fork, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |