xfs
[Top] [All Lists]

Re: [PATCH 35/76] libxfs: refactor short btree block verification

To: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject: Re: [PATCH 35/76] libxfs: refactor short btree block verification
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 3 Jan 2016 04:18:32 -0800
Cc: david@xxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20151219090014.12713.75657.stgit@xxxxxxxxxxxxxxxx>
References: <20151219085622.12713.88678.stgit@xxxxxxxxxxxxxxxx> <20151219090014.12713.75657.stgit@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
> +/**
> + * xfs_btree_sblock_v5hdr_verify() -- verify the v5 fields of a short-format
> + *                                 btree block
> + *
> + * @bp: buffer containing the btree block
> + * @max_recs: pointer to the m_*_mxr max records field in the xfs mount
> + * @pag_max_level: pointer to the per-ag max level field
> + */

We're so far avoided using kerneldoc comments and they silly super
verbosity in XFS.  It might be good to tone this down to the normal
XFS level (same for some other patches).

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>