| To: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 02/76] xfs: fix log ticket type printing |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sun, 3 Jan 2016 04:13:53 -0800 |
| Cc: | david@xxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20151219085636.12713.59155.stgit@xxxxxxxxxxxxxxxx> |
| References: | <20151219085622.12713.88678.stgit@xxxxxxxxxxxxxxxx> <20151219085636.12713.59155.stgit@xxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
On Sat, Dec 19, 2015 at 12:56:36AM -0800, Darrick J. Wong wrote: > Update the log ticket reservation type printing code to reflect > all the types of log tickets, to avoid incorrect debug output and > avoid running off the end of the array. This looks okay, but I think we should use name array initializers to make sure it doesn't got out of sync ever. Also I don't think we'd ever run past the array as the users does a size check. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 3/3] xfs: cancel COW in xfs_cancel_ioend, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 05/76] libxfs: pack the agfl header structure so XFS_AGFL_SIZE is correct, Christoph Hellwig |
| Previous by Thread: | reflink fixes, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 02/76] xfs: fix log ticket type printing, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |