| To: | Vivek Trivedi <t.vivek@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v2 2/4] xfsprogs: fix integer overflow in xlog_find_verify_cycle |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sun, 20 Dec 2015 07:35:13 -0800 |
| Cc: | xfs@xxxxxxxxxxx, a.sahrawat@xxxxxxxxxxx, pankaj.m@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1449832143-26356-3-git-send-email-t.vivek@xxxxxxxxxxx> |
| References: | <1449832143-26356-1-git-send-email-t.vivek@xxxxxxxxxxx> <1449832143-26356-3-git-send-email-t.vivek@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
On Fri, Dec 11, 2015 at 04:39:01PM +0530, Vivek Trivedi wrote: > Fix unintentional integer overflow in xlog_find_verify_cycle. > Reported by coverity. xfs_daddr_t is a 64-bit integer. How does replacing it with an int fix overlows? xlog_find_verify_cycle originates in the kernel code, so any fix should probably be done there first. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH v2 1/4] xfsprogs: xfs_io: fix a memory leak in imap_f, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH v2 3/4] xfsprogs: mkfs: fix unintentional integer overflow, Christoph Hellwig |
| Previous by Thread: | [PATCH v2 2/4] xfsprogs: fix integer overflow in xlog_find_verify_cycle, Vivek Trivedi |
| Next by Thread: | Re: [PATCH v2 2/4] xfsprogs: fix integer overflow in xlog_find_verify_cycle, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |