| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: Re: [PATCH 03/11] xfsprogs: mkfs: fix unintentional integer overflow |
| From: | VIVEK TRIVEDI <t.vivek@xxxxxxxxxxx> |
| Date: | Fri, 04 Dec 2015 12:03:18 +0000 (GMT) |
| Cc: | "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, AMIT SAHRAWAT <a.sahrawat@xxxxxxxxxxx>, PANKAJ MISHRA <pankaj.m@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| Dlp-filter: | Pass |
| Msgkey: | 20151204120157269@xxxxxxx |
| Reply-to: | t.vivek@xxxxxxxxxxx |
>I dislike unexplained casts in code like this. Nobody knows exactly >why it is there. A better fix is to change the definition of >rswidth to a 64 bit type so casts are not ever necessary... thanks for review! I will resend updated patch. thanks! |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Re: [PATCH 02/11] xfsprogs: fix integer overflow in xlog_find_verify_cycle, VIVEK TRIVEDI |
|---|---|
| Next by Date: | Re: Re: [PATCH 04/11] xfsprogs: xfsdb: remove unnessary checks in process_leaf_node_dir_v2_free, VIVEK TRIVEDI |
| Previous by Thread: | Re: Re: [PATCH 02/11] xfsprogs: fix integer overflow in xlog_find_verify_cycle, VIVEK TRIVEDI |
| Next by Thread: | Re: Re: [PATCH 04/11] xfsprogs: xfsdb: remove unnessary checks in process_leaf_node_dir_v2_free, VIVEK TRIVEDI |
| Indexes: | [Date] [Thread] [Top] [All Lists] |