| To: | Vivek Trivedi <t.vivek@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 11/11] xfsprogs: xfs_repair: fix possible null pointer dereference in mark_standalone_inodes |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Thu, 3 Dec 2015 17:34:08 +1100 |
| Cc: | xfs@xxxxxxxxxxx, a.sahrawat@xxxxxxxxxxx, pankaj.m@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1449055167-19936-12-git-send-email-t.vivek@xxxxxxxxxxx> |
| References: | <1449055167-19936-1-git-send-email-t.vivek@xxxxxxxxxxx> <1449055167-19936-12-git-send-email-t.vivek@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Wed, Dec 02, 2015 at 04:49:27PM +0530, Vivek Trivedi wrote: > Fix possible null pointer dereference in mark_standalone_inodes by > rearranging and adding ASSERT for null irec. > Reported by coverity. Makes no difference if we assert fail or segv, it's the same result. Hence I don't see any point in adding asserts like this - we don't do it for the kernel code because it's just noise and it's essentially the same here... Just tell coverity to ignore this warnings... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 10/11] xfsprogs: fix possible null pointer dereference in xfs_iformat_extents, Dave Chinner |
|---|---|
| Next by Date: | Re: xfstest failure with xfs, dax and v4.4-rc3, Dave Chinner |
| Previous by Thread: | [PATCH 11/11] xfsprogs: xfs_repair: fix possible null pointer dereference in mark_standalone_inodes, Vivek Trivedi |
| Next by Thread: | [PATCH 09/11] xfsprogs: xfs_repair: fix possible null dereference in traverse_int_dir2block, Vivek Trivedi |
| Indexes: | [Date] [Thread] [Top] [All Lists] |