Re: [PATCH 09/11] xfsprogs: xfs_repair: fix possible null dereference in traverse_int_dir2block

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Wed, Dec 02, 2015 at 11:51:31PM -0600, Eric Sandeen wrote:
> On 12/2/15 5:19 AM, Vivek Trivedi wrote:
> > Fix possible null dereference in traverse_int_dir2block if buffer pointer 
> > is NULL.
> > Reported by coverity.
> 
> Hm, against what version of xfsprogs?
> 
> traverse_int_dir2block has been gone for a while now.  Can you please recheck
> against current git, and if there's still an issue, explain a bit more;
> I don't see offhand how we get a bp back from da_read_buf with a null 
> bp->b_addr.

it's also worth pointing out that there are several callers of
da_read_buf() in this function, all of which have identical error
checking and hence are all going to have the same problem if it
does actually exist.

When coverity issues a warning, we really need to check all
instances of the same code for the same problem, even if coverity
doesn't warn about the other call sites....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx