On Wed, Dec 02, 2015 at 06:07:47PM +0100, Arkadiusz MiÅkiewicz wrote:
> On Wednesday 02 of December 2015, Eric Sandeen wrote:
>
> > >> How about just checking running kernel version before enabling this by
> > >> default?
> > >
> > > The btrfs solution? No thanks.
> >
> > Another option is to export features the running kernel can handle in
> > sysfs & mkfs accordingly - but then somebody mkfs's under one kernel,
> > boots another kernel, and gets different mkfs's, possibly fails to mount,
> > etc... magically changing defaults is a nightmare. yeah, at some point
> > you have to realize that you cannot save everyone from themselves. ;)
>
> Don't change default. Warn instead about mkfs using feature not supported by
> current kernel.
That's just as bad - we'll get people complaining about mkfs
warnings they don't care about. And we will also end up with people
not turning on options they really should be using, like metadata
CRCs....
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
|