xfs
[Top] [All Lists]

[PATCH 06/11] xfsprogs: xfs_db: check null derefernce after block_to_bt

To: xfs@xxxxxxxxxxx
Subject: [PATCH 06/11] xfsprogs: xfs_db: check null derefernce after block_to_bt
From: Vivek Trivedi <t.vivek@xxxxxxxxxxx>
Date: Wed, 02 Dec 2015 16:49:22 +0530
Cc: a.sahrawat@xxxxxxxxxxx, pankaj.m@xxxxxxxxxxx, Vivek Trivedi <t.vivek@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dlp-filter: Pass
In-reply-to: <1449055167-19936-1-git-send-email-t.vivek@xxxxxxxxxxx>
References: <1449055167-19936-1-git-send-email-t.vivek@xxxxxxxxxxx>
add assert if block_to_bt returns NULL to avoid null pointer
dereference and get backtrace.
Reported by coverity.

Signed-off-by: Vivek Trivedi <t.vivek@xxxxxxxxxxx>
---
 db/btblock.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/db/btblock.c b/db/btblock.c
index 46140fc..91593f8 100644
--- a/db/btblock.c
+++ b/db/btblock.c
@@ -180,6 +180,7 @@ btblock_key_offset(
        struct xfs_db_btree     *bt = block_to_bt(block);
        int                     offset;
 
+       ASSERT(bt != NULL);
        ASSERT(startoff == 0);
        ASSERT(block->bb_level != 0);
 
@@ -201,6 +202,7 @@ btblock_ptr_offset(
        int                     offset;
        int                     maxrecs;
 
+       ASSERT(bt != NULL);
        ASSERT(startoff == 0);
        ASSERT(block->bb_level != 0);
 
@@ -225,6 +227,7 @@ btblock_rec_offset(
        struct xfs_db_btree     *bt = block_to_bt(block);
        int                     offset;
 
+       ASSERT(bt != NULL);
        ASSERT(startoff == 0);
        ASSERT(block->bb_level == 0);
 
-- 
1.7.9.5

<Prev in Thread] Current Thread [Next in Thread>