xfs
[Top] [All Lists]

[PATCH 03/11] xfsprogs: mkfs: fix unintentional integer overflow

To: xfs@xxxxxxxxxxx
Subject: [PATCH 03/11] xfsprogs: mkfs: fix unintentional integer overflow
From: Vivek Trivedi <t.vivek@xxxxxxxxxxx>
Date: Wed, 02 Dec 2015 16:49:19 +0530
Cc: a.sahrawat@xxxxxxxxxxx, pankaj.m@xxxxxxxxxxx, Vivek Trivedi <t.vivek@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dlp-filter: Pass
In-reply-to: <1449055167-19936-1-git-send-email-t.vivek@xxxxxxxxxxx>
References: <1449055167-19936-1-git-send-email-t.vivek@xxxxxxxxxxx>
Fix unintentional integer overflow  in mkfs.
Reported by coverity.

Signed-off-by: Vivek Trivedi <t.vivek@xxxxxxxxxxx>
---
 mkfs/xfs_mkfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 7cba41a..e540c48 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -2033,7 +2033,7 @@ _("warning: sparse inodes not supported without CRC 
support, disabled.\n"));
                /* check that rswidth is a multiple of fs blocksize */
                if (!norsflag && rswidth && !(BBTOB(rswidth) % blocksize)) {
                        rswidth = DTOBT(rswidth);
-                       rtextbytes = rswidth << blocklog;
+                       rtextbytes = (__uint64_t)rswidth << blocklog;
                        if (XFS_MIN_RTEXTSIZE <= rtextbytes &&
                            (rtextbytes <= XFS_MAX_RTEXTSIZE)) {
                                rtextblocks = rswidth;
-- 
1.7.9.5

<Prev in Thread] Current Thread [Next in Thread>