xfs
[Top] [All Lists]

[PATCH 04/11] xfsprogs: xfsdb: remove unnessary checks in process_leaf_n

To: xfs@xxxxxxxxxxx
Subject: [PATCH 04/11] xfsprogs: xfsdb: remove unnessary checks in process_leaf_node_dir_v2_free
From: Vivek Trivedi <t.vivek@xxxxxxxxxxx>
Date: Wed, 02 Dec 2015 16:49:20 +0530
Cc: a.sahrawat@xxxxxxxxxxx, pankaj.m@xxxxxxxxxxx, Vivek Trivedi <t.vivek@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dlp-filter: Pass
In-reply-to: <1449055167-19936-1-git-send-email-t.vivek@xxxxxxxxxxx>
References: <1449055167-19936-1-git-send-email-t.vivek@xxxxxxxxxxx>
xfs_dir2_free_hdr_t entries are unsigned, so they can't be negative.
remove these unnessary checks in process_leaf_node_dir_v2_free.
Reported by coverity.

Signed-off-by: Vivek Trivedi <t.vivek@xxxxxxxxxxx>
---
 db/check.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/db/check.c b/db/check.c
index 9c1541d..9d986b9 100644
--- a/db/check.c
+++ b/db/check.c
@@ -3073,9 +3073,7 @@ process_leaf_node_dir_v3_free(
                return;
        }
        if (be32_to_cpu(free->hdr.nvalid) > maxent || 
-                               be32_to_cpu(free->hdr.nvalid) < 0 ||
                                be32_to_cpu(free->hdr.nused) > maxent || 
-                               be32_to_cpu(free->hdr.nused) < 0 ||
                                be32_to_cpu(free->hdr.nused) > 
                                        be32_to_cpu(free->hdr.nvalid)) {
                if (!sflag || v)
-- 
1.7.9.5

<Prev in Thread] Current Thread [Next in Thread>