xfs
[Top] [All Lists]

Re: [PATCH 2/2] generic/15[78]: fix error messages in the golden output

To: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject: Re: [PATCH 2/2] generic/15[78]: fix error messages in the golden output
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 21 Nov 2015 10:14:51 -0800
Cc: david@xxxxxxxxxxxxx, fstests@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, hch@xxxxxxxxxxxxx, tao.peng@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, Anna.Schumaker@xxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20151121180644.GA23916@xxxxxxxxxxxxx>
References: <20151121005001.20398.92856.stgit@xxxxxxxxxxxxxxxx> <20151121005014.20398.22316.stgit@xxxxxxxxxxxxxxxx> <20151121180644.GA23916@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
> Shouldn't these be Invalid argument just like the
> to a device case above or the clone case?

E.g. something like this on top of your patch:


diff --git a/tests/generic/158.out b/tests/generic/158.out
index 1210429..dff3692 100644
--- a/tests/generic/158.out
+++ b/tests/generic/158.out
@@ -16,9 +16,9 @@ XFS_IOC_FILE_EXTENT_SAME: Invalid argument
 Try to dedupe to a dir
 TEST_DIR/test-158/dir1: Is a directory
 Try to dedupe to a device
-dedupe: Operation not supported
+dedupe: Invalid argument
 Try to dedupe to a fifo
-dedupe: Operation not supported
+dedupe: Invalid argument
 Try to dedupe an append-only file
 Dedupe two files
 Check scratch fs

<Prev in Thread] Current Thread [Next in Thread>