| To: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/2] generic/15[78]: fix error messages in the golden output |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sat, 21 Nov 2015 10:06:44 -0800 |
| Cc: | david@xxxxxxxxxxxxx, fstests@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, hch@xxxxxxxxxxxxx, tao.peng@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, Anna.Schumaker@xxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20151121005014.20398.22316.stgit@xxxxxxxxxxxxxxxx> |
| References: | <20151121005001.20398.92856.stgit@xxxxxxxxxxxxxxxx> <20151121005014.20398.22316.stgit@xxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
> --- a/tests/generic/158.out > +++ b/tests/generic/158.out > Try to dedupe a device > -XFS_IOC_FILE_EXTENT_SAME: Permission denied > +XFS_IOC_FILE_EXTENT_SAME: Invalid argument > Try to dedupe to a dir > -/mnt/test-158/dir1: Is a directory > +TEST_DIR/test-158/dir1: Is a directory > Try to dedupe to a device > -dedupe: Permission denied > +dedupe: Operation not supported > Try to dedupe to a fifo > -dedupe: Permission denied > +dedupe: Operation not supported Shouldn't these be Invalid argument just like the to a device case above or the clone case? Otherwise looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 2/2] generic/15[78]: fix error messages in the golden output, Darrick J. Wong |
|---|---|
| Next by Date: | Re: [PATCH 2/2] generic/15[78]: fix error messages in the golden output, Christoph Hellwig |
| Previous by Thread: | [PATCH 2/2] generic/15[78]: fix error messages in the golden output, Darrick J. Wong |
| Next by Thread: | Re: [PATCH 2/2] generic/15[78]: fix error messages in the golden output, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |