xfs
[Top] [All Lists]

Re: clone ioctl return values

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: clone ioctl return values
From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Date: Tue, 17 Nov 2015 15:33:20 +0000
Cc: Chris Mason <clm@xxxxxx>, "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20151117152251.GA5392@xxxxxxxxxxxxx>
References: <20151116120431.GA2860@xxxxxxxxxxxxx> <20151117002822.GA32467@xxxxxxxxxxxxxxxx> <20151117105433.GA18093@xxxxxxxxxxxxx> <20151117135745.GF17545@xxxxxxxxxxxxxxxxxxx> <20151117152251.GA5392@xxxxxxxxxxxxx>
Sender: Al Viro <viro@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Nov 17, 2015 at 07:22:52AM -0800, Christoph Hellwig wrote:

> Yes, I saw that.  So so far I'd suggest something like the following
> for btrfs:
> 
>  - return EBADFD for missing read/wite permissions

Yowwwch...  What the hell does that have to do with STREAMS?  Or are you
using EBADFD as "nobody uses that error value anyway, let's assign it
whatever meaning we need"?

Besides, that'll be confused with EBADF all the time.  I strongly
recommend against that.

<Prev in Thread] Current Thread [Next in Thread>