| To: | Jan Kara <jack@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v2 03/11] pmem: enable REQ_FUA/REQ_FLUSH handling |
| From: | Dan Williams <dan.j.williams@xxxxxxxxx> |
| Date: | Mon, 16 Nov 2015 09:28:59 -0800 |
| Cc: | Andreas Dilger <adilger@xxxxxxxxx>, Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, "J. Bruce Fields" <bfields@xxxxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Jan Kara <jack@xxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, linux-ext4 <linux-ext4@xxxxxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, Linux MM <linux-mm@xxxxxxxxx>, "linux-nvdimm@xxxxxxxxxxxx" <linux-nvdimm@xxxxxxxxxxxx>, X86 ML <x86@xxxxxxxxxx>, XFS Developers <xfs@xxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel_com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=eTlQHDOWTN7nhMc5bf86Wz6dyuZNKdiiSQOlmtrXMYk=; b=D+35hgPpO2cLFBy9QgN9fqf155AHf2ZiJGN/IR0xC/nYVlhHxYRiBS91jv4ZkjWX/4 Ph64y4pG5m+OIrENA/ON+o4WvBlVLeBSpT9nuaeKJStu5howOVIg7eDOu4yDVWcoUQ3x 4JzjS3qqJgu+EHMmQp29aGZG4n4u58w4KN7aCsWAh6OldVf0nK05dkXRwXMkHHNrw5J6 suyKHgFh6BZDAnMPQo/0S7y0rmCHDMGSk74wtesRqITLkD886yBmGzObUcPoDFsCrv7U wWiQqFNiZIS3g1Js1YoJhCT0lZtMObehot7cg6DxCn5ySsPMY9NRN2XN+WChz7OZNLpR cbtQ== |
| In-reply-to: | <20151116140526.GA6733@xxxxxxxxxxxxx> |
| References: | <1447459610-14259-1-git-send-email-ross.zwisler@xxxxxxxxxxxxxxx> <1447459610-14259-4-git-send-email-ross.zwisler@xxxxxxxxxxxxxxx> <CAPcyv4j4arHE+iAALn1WPDzSb_QSCDy8udtXU1FV=kYSZDfv8A@xxxxxxxxxxxxxx> <22E0F870-C1FB-431E-BF6C-B395A09A2B0D@xxxxxxxxx> <CAPcyv4jwx3VzyRugcpH7KCOKM64kJ4Bq4wgY=iNJMvLTHrBv-Q@xxxxxxxxxxxxxx> <20151116133714.GB3443@xxxxxxxxxxxxx> <20151116140526.GA6733@xxxxxxxxxxxxx> |
On Mon, Nov 16, 2015 at 6:05 AM, Jan Kara <jack@xxxxxxx> wrote: > On Mon 16-11-15 14:37:14, Jan Kara wrote: [..] > But a question: Won't it be better to do sfence + pcommit only in response > to REQ_FLUSH request and don't do it after each write? I'm not sure how > expensive these instructions are but in theory it could be a performance > win, couldn't it? For filesystems this is enough wrt persistency > guarantees... We would need to gather the performance data... The expectation is that the cache flushing is more expensive than the sfence + pcommit. |
| Previous by Date: | Re: [PATCH v2 00/11] DAX fsynx/msync support, Dan Williams |
|---|---|
| Next by Date: | [PATCH] xfs: get mp from bma->ip in xfs_bmap code, Eric Sandeen |
| Previous by Thread: | Re: [PATCH v2 03/11] pmem: enable REQ_FUA/REQ_FLUSH handling, Jan Kara |
| Next by Thread: | Re: [PATCH v2 03/11] pmem: enable REQ_FUA/REQ_FLUSH handling, Ross Zwisler |
| Indexes: | [Date] [Thread] [Top] [All Lists] |