| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls |
| From: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> |
| Date: | Thu, 12 Nov 2015 09:34:27 -0800 |
| Cc: | david@xxxxxxxxxxxxx, fstests@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, tao.peng@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, Anna.Schumaker@xxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20151112125115.GA28822@xxxxxxxxxxxxx> |
| References: | <20151111192628.15056.6451.stgit@xxxxxxxxxxxxxxxx> <20151112090756.GA25685@xxxxxxxxxxxxx> <20151112125115.GA28822@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Nov 12, 2015 at 04:51:15AM -0800, Christoph Hellwig wrote: > On Thu, Nov 12, 2015 at 01:07:56AM -0800, Christoph Hellwig wrote: > > Looks fine: > > > > Acked-by: Christoph Hellwig <hch@xxxxxx> > > Actually I take this back. I had though this was the existing series > with my fixes, but this one still incorrectly assumes that if reflink > works dedup works as well, leading to lots of false failures on nfs. Bleargh, _require_*_dedupe forgot to check for ENOTTY output, so all the dedupe tests should have _notrun. Also, generic/806 was calling the wrong _require. I'll start renumbering tests; Christoph, did you see anything else? --D > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html |
| Previous by Date: | Re: [PATCH V2] xfs: create helper for bmap finish & trans join in attr code, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls, Christoph Hellwig |
| Previous by Thread: | Re: [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls, Christoph Hellwig |
| Next by Thread: | Re: [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |