xfs
[Top] [All Lists]

Re: [RFCv3 00/12] xfstests: test the btrfs/xfs reflink/dedupe ioctls

To: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject: Re: [RFCv3 00/12] xfstests: test the btrfs/xfs reflink/dedupe ioctls
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 11 Nov 2015 05:56:39 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, david@xxxxxxxxxxxxx, fstests@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, Anna.Schumaker@xxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20151109184913.GB3255@xxxxxxxxxxxxxxxx>
References: <20151007051257.3260.73072.stgit@xxxxxxxxxxxxxxxx> <20151109075926.GB17974@xxxxxxxxxxxxx> <20151109184913.GB3255@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Mon, Nov 09, 2015 at 10:49:13AM -0800, Darrick J. Wong wrote:
> I found a few more bugs in the kernel-side implementation, which might explain
> that.  I'm about to start working on making CoW less crappy, but I'll push all
> the patches out to github.  (I wasn't planning on patchbombing again until
> December.)

Yes, please push your WIP code out as often as possible!

Btw, here is another additional fixup, as two tests were wrongly
tagged as needing reflink instead of dedupe:


diff --git a/tests/generic/827 b/tests/generic/827
index cc1bc52..c8ce7cf 100755
--- a/tests/generic/827
+++ b/tests/generic/827
@@ -47,7 +47,7 @@ _supported_fs generic
 _supported_os Linux
 
 _require_scratch
-_require_xfs_io_command "reflink"
+_require_xfs_io_command "dedupe"
 
 echo "Format and mount"
 _scratch_mkfs > $seqres.full 2>&1
diff --git a/tests/generic/828 b/tests/generic/828
index 1757985..f5b7298 100755
--- a/tests/generic/828
+++ b/tests/generic/828
@@ -47,7 +47,7 @@ _supported_fs generic
 _supported_os Linux
 
 _require_scratch
-_require_xfs_io_command "reflink"
+_require_xfs_io_command "dedupe"
 
 echo "Format and mount"
 _scratch_mkfs > $seqres.full 2>&1

<Prev in Thread] Current Thread [Next in Thread>