xfs
[Top] [All Lists]

Re: [PATCH v2 03/51] xfs_io: support reflink and dedupe of file ranges

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2 03/51] xfs_io: support reflink and dedupe of file ranges
From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Date: Mon, 9 Nov 2015 22:27:58 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20151109213520.GB14311@dastard>
References: <20151007050513.1504.28089.stgit@xxxxxxxxxxxxxxxx> <20151007050533.1504.66249.stgit@xxxxxxxxxxxxxxxx> <20151014053656.GJ10397@xxxxxxxxxxxxxxxx> <20151109075438.GA17974@xxxxxxxxxxxxx> <20151109183311.GA3255@xxxxxxxxxxxxxxxx> <20151109185724.GB2224@xxxxxxxxxxxxxxxx> <20151109213520.GB14311@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Nov 10, 2015 at 08:35:20AM +1100, Dave Chinner wrote:
> On Mon, Nov 09, 2015 at 10:57:24AM -0800, Darrick J. Wong wrote:
> > On Mon, Nov 09, 2015 at 10:33:12AM -0800, Darrick J. Wong wrote:
> > > On Sun, Nov 08, 2015 at 11:54:38PM -0800, Christoph Hellwig wrote:
> > > > Any reason why the dedup command is called 'dedupe'?  Is this a revenge
> > > > for the missing 'e' in the creat syscall? :)
> > > 
> > > Heh, sure! :)
> > > 
> > > I stuck on the 'e' because the btrfs tool is 'duperemove', not 
> > > 'dupremove'.
> > > 
> > > (I have no preference either way.)
> > > 
> > > > Either way it would be good to get this support in ASAP so we can have
> > > > the command ready for xfstests and we can merge the test.  They are
> > > > useful for btrfs and NFS already, so I'd love to fast track them.
> > 
> > Oh. Heh.  I forgot that Dave merged the v1 patch into for-next after I'd 
> > posted
> > the v2 patch.  So ... I thought I'd convinced him to revert the v1 patch and
> > stuff in the v2 patch, but that hasn't shown up on kernel.org.
> > 
> > -ETOOMANYPATCHES :(
> 
> Need to push it out - I have an updated branch here, just been
> delayed in testing and pushing out progs-4.3-rc2.

Ok, thanks, I'll rebase and give the tests a spin in the morning.

--D

> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>