xfs
[Top] [All Lists]

Re: [PATCH v13 12/51] vfs: Cache richacl in struct inode

To: Andreas Dilger <adilger@xxxxxxxxx>
Subject: Re: [PATCH v13 12/51] vfs: Cache richacl in struct inode
From: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
Date: Wed, 4 Nov 2015 23:10:43 +0100
Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, "J. Bruce Fields" <bfields@xxxxxxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxxxxxxx>, Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>, Anna Schumaker <anna.schumaker@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, linux-ext4 <linux-ext4@xxxxxxxxxxxxxxx>, XFS Developers <xfs@xxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, Linux NFS Mailing List <linux-nfs@xxxxxxxxxxxxxxx>, linux-cifs@xxxxxxxxxxxxxxx, Linux API <linux-api@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat_com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ygp3jgQbPLAGLPq1REX2wehuTHOjOU3mLdpD8mf54NI=; b=dypT4c0fPiTegfnNGmzvog9FRzyUonor17cfj75JZHbTqLH1tpPYK1V5xReCFeXjZW kpLTEFuJO87Rk8m/mqtd5Ev+ghXowiA5SixhcQ04gQfKYvYYXeuWGHTrjlJmArqYDuui 4rCzdpGTblqToyem4ezZnqhhfnRAH/otV/i+wRwqP6vkwMWj5xM0sFgBphJ4Tdjz6iIG 8LaOT6PL/xe+e79PvTTGmtmSuiItvYXd1Azj1eTPq5uGF62gXiGj4EEweTcOmBt0riHw bgWnsROERFXic2eAXcE6yn/wxRGZxLiPk3X9uWLmItUajVchLwtm/5nBU82dMCZ4piYD GAfg==
In-reply-to: <713E53A4-D073-4745-B57D-77AD07E89957@xxxxxxxxx>
References: <1446563847-14005-1-git-send-email-agruenba@xxxxxxxxxx> <1446563847-14005-13-git-send-email-agruenba@xxxxxxxxxx> <713E53A4-D073-4745-B57D-77AD07E89957@xxxxxxxxx>
Andreas,

On Wed, Nov 4, 2015 at 3:03 AM, Andreas Dilger <adilger@xxxxxxxxx> wrote:
>> @@ -33,7 +33,7 @@ richacl_alloc(int count, gfp_t gfp)
>>       struct richacl *acl = kzalloc(size, gfp);
>>
>>       if (acl) {
>> -             atomic_set(&acl->a_refcount, 1);
>> +             atomic_set(&acl->a_base.ba_refcount, 1);
>>               acl->a_count = count;
>>       }
>>       return acl;
>> @@ -52,7 +52,7 @@ richacl_clone(const struct richacl *acl, gfp_t gfp)
>>
>>       if (dup) {
>>               memcpy(dup, acl, size);
>> -             atomic_set(&dup->a_refcount, 1);
>> +             atomic_set(&dup->a_base.ba_refcount, 1);
>
> These two calls should be base_acl_init().

Yes. This should all be fixed in the next snapshot.

Thanks,
Andreas

<Prev in Thread] Current Thread [Next in Thread>