xfs
[Top] [All Lists]

Re: [PATCH v13 45/51] sunrpc: Allow to demand-allocate pages to encode i

To: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
Subject: Re: [PATCH v13 45/51] sunrpc: Allow to demand-allocate pages to encode into
From: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>
Date: Tue, 3 Nov 2015 11:25:46 -0500
Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, Andreas Dilger <adilger.kernel@xxxxxxxxx>, "J. Bruce Fields" <bfields@xxxxxxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxxxxxxx>, Anna Schumaker <anna.schumaker@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Linux FS-devel Mailing List <linux-fsdevel@xxxxxxxxxxxxxxx>, Linux NFS Mailing List <linux-nfs@xxxxxxxxxxxxxxx>, linux-cifs@xxxxxxxxxxxxxxx, Linux API Mailing List <linux-api@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=primarydata_com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=dLaT4nvAJq5p3EA2H/rcBJTFSLruL20tLhtHHkml+o8=; b=bleB/9fi6qr7N5fzWEVpaWLzTk7QsB7C8WA+AtOzLjE+XL4h2fGmMpq6CUwVd4vVTN y9wvKi3vFmm/BJWfy8FREaAaRyz1ZTRLVY6ySTh78+r+WlOzc2ET3NK5bTNkNqXDMt1i xJPTqWA/vY/UtyATjuFJVvzVoZl6pGxQEA/vCHLnCzetYBJwWKURCD6tjtygKOMETl4g EIN6CbgVhG4sNo60EHQLRxuJCWT+1UEj9KvGNcdo+Ik4n2RPpdHfPZ/JJVrbAWxA+yL1 R6bhJNEXPPE9eqEPPexpZsRxvLhPiSWoKBVnotEAosXhI0vZ5rIF8fE9e0f28W+zSINK pOKw==
In-reply-to: <1446563847-14005-46-git-send-email-agruenba@xxxxxxxxxx>
References: <1446563847-14005-1-git-send-email-agruenba@xxxxxxxxxx> <1446563847-14005-46-git-send-email-agruenba@xxxxxxxxxx>
On Tue, Nov 3, 2015 at 10:17 AM, Andreas Gruenbacher
<agruenba@xxxxxxxxxx> wrote:
> When encoding large, variable-length objects such as acls into xdr_bufs,
> it is easier to allocate buffer pages on demand rather than precomputing
> the required buffer size.
>

NACK. We're not doing allocations from inside the XDR encoders. This
can and should be done before calling into the SUNRPC layer.

Trond

<Prev in Thread] Current Thread [Next in Thread>