xfs
[Top] [All Lists]

Re: [PATCH v2 0/5] xfs: SGI ACL Fixes

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2 0/5] xfs: SGI ACL Fixes
From: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
Date: Mon, 2 Nov 2015 04:41:30 +0100
Cc: Brian Foster <bfoster@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat_com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=PggG/W8oWZzrjgc+fiyGK62ciddT7QbaXDXHAw3wk/4=; b=k4uLjHf6V7hrHnjhYdRUZ5mC+w3YB9NxqilfFTsqGrCjy1HNGlzIPwpxrp0uEb5zbU yg+Zopt6Dq+0ogcCa5q4yrDKh8hTi5bxeA4vGWX+bVkPpoLqRj4wkfMKLZNN/IHqVZT1 d2NIvP4HU+56QkQjMeKZ0qYdnGD6IFM7Ov6S05SPcDd+l+64otfviYz97ewayZ0aAC1u zb8f43Uo3h9jnrqq+nJ5Q2qBCLf6IQ2kcT5qVbG5kSlBvTIm8GGky2ZwI2pDzpWMBos5 A52x+8bXVhAV+RXZPzhjXlC61PZ2pcOFzXCrd2eFSImPsj9r9YESkgjWDQWtDm0CY4sL XbBA==
In-reply-to: <20151102025352.GY19199@dastard>
References: <1446217508-22157-1-git-send-email-agruenba@xxxxxxxxxx> <20151102025352.GY19199@dastard>
On Mon, Nov 2, 2015 at 3:53 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> On Fri, Oct 30, 2015 at 04:05:03PM +0100, Andreas Gruenbacher wrote:
>> Here is a reworked patch queue that also handles setting 
>> SGI_ACL_{FILE,DEFAULT}
>> via XFS_IOC_ATTRMULTI_BY_HANDLE.  Please review.
>>
>> Thanks,
>> Andreas
>>
>> Andreas Gruenbacher (5):
>>   xfs: Validate the length of on-disk ACLs
>>   xfs: Plug memory leak in xfs_attrmulti_attr_set
>
> Ok, I've taken these two patches for the upcoming merge window as
> they fix bugs, but I've taken Brian's cached ACL invalidation patch
> instead of these:
>
>>   xfs: SGI ACLs: Fix caching and mode setting
>>   xfs: Add namespace parameter to the xfs kuid/kgid <=> uid/gid wrappers
>>   xfs: SGI ACLs: Map uid/gid namespaces
>
> I'm not yet convinced that these patches are the right way to solve
> the given issue as they may interact badly with xfsdump/restore.

Well, what else do you need to be convinced? I guess it won't help if
I try to explain everything all over again?

Thanks,
Andreas

<Prev in Thread] Current Thread [Next in Thread>