Re: [PATCH 2/4] xfs: SGI ACLs: Fix caching and mode setting

[Andreas Gruenbacher <agruenba@xxxxxxxxxx>]

On Mon, Oct 26, 2015 at 3:02 PM, Brian Foster <bfoster@xxxxxxxxxx> wrote:
> Finally, another random thought... another way to approach this whole
> thing might be just to redirect the SGI_FILE_* xattr calls to the
> system.posix_acl_* calls.

You mean silently changing the binary format of those attributes?
That's the worst thing we could possibly do.

> The SGI_FILE_* xattr data changes along with the required conversions
> and whatnot, but then at least we expose data in a more generic format.

I really doubt that we can get rid of those attributes.

The patches in this queue don't "change" the format of those
attributes, they only fix them for use in UID/GID  namespaces where
they are currently broken. Validation when setting those xattrs could
be removed, allowing sysadmins to set acls which the kernel and
xfs_repair would reject; it seems rather pointless though.

Thanks,
Andreas