xfs
[Top] [All Lists]

Re: [PATCH] xfs_io: implement 'inode' command V3

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH] xfs_io: implement 'inode' command V3
From: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Date: Fri, 23 Oct 2015 11:29:46 +0200
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20151022144255.GB13661@xxxxxxxxxxxxxxx>
Mail-followup-to: Brian Foster <bfoster@xxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <1445257880-30797-1-git-send-email-cmaiolino@xxxxxxxxxx> <20151022144255.GB13661@xxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
Thanks for the review Brian, I'll walk over it and fix the points you mentioned.
> 
> 
> I still don't really get why we have separate -l and -s options here. It
> seems to me that the behavior of -l already gives us the information
> that -s does. Even if that's not obvious enough, the -l command could
> just print out both. For example:
> 
>       "Largest inode: 1234 (32-bit)"

I agree with you here, but, I'll let Dave answer this question, maybe he had 
some another idea for it that I'm not aware of. 

Cheers.
-- 
Carlos

<Prev in Thread] Current Thread [Next in Thread>