| To: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 03/12] generic/80[0-2]: support xfs in addition to btrfs |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 15 Oct 2015 02:19:44 -0700 |
| Cc: | david@xxxxxxxxxxxxx, fstests@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, Anna.Schumaker@xxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20151007051323.3260.60421.stgit@xxxxxxxxxxxxxxxx> |
| References: | <20151007051257.3260.73072.stgit@xxxxxxxxxxxxxxxx> <20151007051323.3260.60421.stgit@xxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
> +# this test requires the test fs support reflink...
> +#
> +_require_test_reflink()
> +{
> + case $FSTYP in
> + xfs)
> + xfs_info "${TEST_DIR}" | grep reflink=1 -c -q || _notrun "Reflink not
> supported by this filesystem type: $FSTYP"
> + ;;
> + btrfs)
> + true
> + ;;
> + *)
> + _notrun "Reflink not supported by this filesystem type: $FSTYP"
> + ;;
> + esac
I don't think that's a good test - we need to check if it's supported by
trying it. That'll automatically get us coverage for other file systems
like xfs.
Note that dedup should get it's own feature check, as currently hacking
nfs into this check will also run dedup tests that can't really be
supported.
|
| Previous by Date: | Re: Any way to slow down fragmentation ?, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH] xfs: more info from kmem deadlocks and high-level error msgs, Carlos Maiolino |
| Previous by Thread: | [PATCH 03/12] generic/80[0-2]: support xfs in addition to btrfs, Darrick J. Wong |
| Next by Thread: | Re: [PATCH 03/12] generic/80[0-2]: support xfs in addition to btrfs, Darrick J. Wong |
| Indexes: | [Date] [Thread] [Top] [All Lists] |