xfs
[Top] [All Lists]

Re: [PATCH v10 44/46] nfs: Add richacl support

To: Anna Schumaker <Anna.Schumaker@xxxxxxxxxx>
Subject: Re: [PATCH v10 44/46] nfs: Add richacl support
From: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
Date: Mon, 12 Oct 2015 21:49:17 +0200
Cc: Andreas Gruenbacher <andreas.gruenbacher@xxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, Andreas Dilger <adilger.kernel@xxxxxxxxx>, "J. Bruce Fields" <bfields@xxxxxxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxxxxxxx>, Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, linux-ext4 <linux-ext4@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, Linux NFS Mailing List <linux-nfs@xxxxxxxxxxxxxxx>, linux-cifs@xxxxxxxxxxxxxxx, Linux API <linux-api@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <561BC61E.6010704@xxxxxxxxxx>
References: <1444604337-17651-1-git-send-email-andreas.gruenbacher@xxxxxxxxx> <1444604337-17651-45-git-send-email-andreas.gruenbacher@xxxxxxxxx> <561BC61E.6010704@xxxxxxxxxx>
Anna,

On Mon, Oct 12, 2015 at 4:39 PM, Anna Schumaker
<Anna.Schumaker@xxxxxxxxxx> wrote:
> I'm not a fan of the "one giant function" approach.  Is there any way to 
> split richacl_from_nfs4_acl() into several smaller functions?

sure, parsing the usr/group identifier could be put in a separate
function, for example.

That function cannot stay as it is right now anyway --- we really need
idmapper to tell us when an identifier string cannot be mapped to a
uid or gid so that we can preserve that identifier.

Thanks,
Andreas

<Prev in Thread] Current Thread [Next in Thread>