xfs
[Top] [All Lists]

Re: [PATCH] xfs: Fix error path in xfs_get_acl

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: Fix error path in xfs_get_acl
From: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
Date: Mon, 12 Oct 2015 05:05:43 +0200
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20151012004539.GA31326@dastard>
References: <1444569791-26719-1-git-send-email-agruenba@xxxxxxxxxx> <20151012004539.GA31326@dastard>
On Mon, Oct 12, 2015 at 2:45 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> Test case for xfstests?

I don't see an easy way to trigger this bug.

> So the entire patch could simply be replaced by:
>
>                 if (error == -ENOATTR)
>                         goto out_update_cache;
> +               acl = ERR_PTR(error);
>                 goto out;
>         }

If you prefer, yes.

Thanks,
Andreas

<Prev in Thread] Current Thread [Next in Thread>