Re: [PATCH 11/14] xfsprogs: Add statvfs64 for osx

[Jan Tulak <jtulak@xxxxxxxxxx>]

On Wed, Sep 23, 2015 at 5:32 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:

On Tue, Sep 15, 2015 at 11:59:21AM +0200, Jan Tulak wrote:
> Simply rename statvfs64 to statfs with a #define.
> OSX version of statvfs is missing some members, so if the renaming
> is in effect (stavfs64 is defined), don't try to use them and go
> directly for the other member value.
>
> Signed-off-by: Jan Tulak <jtulak@xxxxxxxxxx>
> ---
> fsr/xfs_fsr.c    | 14 ++++++++++++++
>Â include/builddefs.in |Â 2 +-
> include/darwin.h  Â| 5 +++++
>Â 3 files changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c
> index e1b7bd6..5f95cdc 100644
> --- a/fsr/xfs_fsr.c
> +++ b/fsr/xfs_fsr.c
> @@ -36,6 +36,12 @@
>Â #Â include <mntent.h>
>Â #endif
>
> +#ifdef __APPLE__
> +//#Â define statvfs64 statfs;
> +#Â include <sys/param.h>
> +#Â include <sys/mount.h>
> +#endif

Why is this here? We've included libxfs.h in this file, so we've
got access to the platform specific includes already, and later in
the patch you put the commented out define there...

âMost likely because I messed it in a rebase during some conflict. I try to check for these things, but apparently this one escaped. Removing it againâ..

Thanks for catching it.

Cheers,

Jan

--

Jan Tulak

jtulak@xxxxxxxxxxÂ/ jan@xxxxxxxx