xfs
[Top] [All Lists]

Re: [PATCH] mkfs.xfs: add [-U uuid] option

To: Mika Eloranta <mika.eloranta@xxxxxxx>
Subject: Re: [PATCH] mkfs.xfs: add [-U uuid] option
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 22 Sep 2015 18:25:09 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <AF226911-F11E-42E8-91F1-10C0E2E31E1D@xxxxxxx>
References: <1442855060-38259-1-git-send-email-mel@xxxxxxx> <20150921221839.GC19114@dastard> <2640913C-6C95-4128-9055-B155AECA0206@xxxxxxx> <20150921233627.GE19114@dastard> <5E0C9EC9-8ABE-47CC-BB7F-2BC0A872AEDB@xxxxxxx> <20150922075249.GI19114@dastard> <AF226911-F11E-42E8-91F1-10C0E2E31E1D@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Sep 22, 2015 at 11:06:35AM +0300, Mika Eloranta wrote:
> > On 22 Sep 2015, at 10:52, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> > Don't get me wrong here - I will take an updated patch from you for
> > this functionality. Both you and Eric have very good points as to
> > why mkfs should allow this, but I need to make sure /I/ understand
> > the bigger picture before committing itâ
> 
> Lesson learned. Coming from my problem domain the feature seemed
> obvious, but I can see the need for being more verbose about the âwhy?â
> part. I did not realize this feature is not so commonly used.

The usual problem - we're all subject matter experts in
our own domains, and what is obvious to us isn't obvious to
someone in a slightly different domain, even though they interact at
some level.

> Regarding updating the patch: â-U uuidâ (mkfs.ext*/mkfs.btrfs -style) or
> "-m uuid=<uuid>â as per proposal by Carlos?

-m uuid=<uuid>, please.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>