xfs
[Top] [All Lists]

Re: [PATCH] mkfs.xfs: add [-U uuid] option

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH] mkfs.xfs: add [-U uuid] option
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 21 Sep 2015 20:42:30 -0500
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150921221839.GC19114@dastard>
References: <1442855060-38259-1-git-send-email-mel@xxxxxxx> <20150921221839.GC19114@dastard>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.2.0
On 9/21/15 5:18 PM, Dave Chinner wrote:
> On Mon, Sep 21, 2015 at 08:04:20PM +0300, Mika Eloranta wrote:
>> The UUID can now be optionally specified during filesystem
>> creation.
> 
> Which UUID are you wanting to set - the metadata uuid or the user
> visible UUID label? Or both?

At mkfs time it should be the same / both.  (the only reason they need
to diverge is a post-mkfs user-visible change on a V5 fs).

 Can you explain the use case for this?
> i.e. I'm trying to work out why Why doesn't mkfs.xfs +
> xfs_admin -U <uuid> doesn't work for you?
> 
> We need some explaination in the commit message so that when we look
> at this in a couple of years time we know why we added this to
> mkfs...

I'm a little curious to know why it's desired, but it's also so trivial
it seems worth accepting if it's useful to someone.

mke2fs (mkfs.ext[234]) and mkfs.btrfs can do this today as well, so
something seems to be driving the desire for the feature.

-Eric

<Prev in Thread] Current Thread [Next in Thread>