Re: [PATCH v2 07/11] xfsprogs: change nftw64 to nftw

[Jan Tulak <jtulak@xxxxxxxxxx>]

--- a/estimate/xfs_estimate.c
+++ b/estimate/xfs_estimate.c
@@ -168,7 +168,7 @@ main(int argc, char **argv)
        ndirs=0LL;       /* number of directories */
        nspecial=0LL;     Â/* number of special files */

-Â Â Â Â Â Â Â Ânftw64(argv[optind], ffn, 40, FTW_PHYS | FTW_MOUNT);
+Â Â Â Â Â Â Â Ânftw(argv[optind], ffn, 40, FTW_PHYS | FTW_MOUNT);

        if (__debug) {
            printf(_("dirsize=%llu\n"), dirsize);
--
2.4.5

Â

âNow I noticed this causes a warning:

xfs_estimate.c:171:3: warning: passing argument 2 of ânftwâ from incompatible pointer type

From ftw.h, the difference is inÂ__nftw_func_t andÂ__nftw64_func_t as a second argument. However, what we pass in the code is "

int

â â

ffn(

â..., struct stat64 *stb, ...)". âIf I change this to struct stat, it works and xfstests -g quick gives the same result as with 64bit variant. So I'm sending an updated patch.

Cheers,

Jan

--

Jan Tulak

jtulak@xxxxxxxxxxÂ/ jan@xxxxxxxx