xfs
[Top] [All Lists]

Re: [PATCH 1/3] xfs: create global stats and stats_clear in sysfs

To: Bill O'Donnell <billodo@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH 1/3] xfs: create global stats and stats_clear in sysfs
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 4 Sep 2015 15:13:49 -0500
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1441371319-31625-2-git-send-email-billodo@xxxxxxxxxx>
References: <1441371319-31625-1-git-send-email-billodo@xxxxxxxxxx> <1441371319-31625-2-git-send-email-billodo@xxxxxxxxxx>
On 9/4/15 7:55 AM, Bill O'Donnell wrote:
> Currently, xfs global stats are in procfs. This patch introduces
> (replicates) the global stats in sysfs. Additionally a stats_clear file
> is introduced in sysfs.
> 
> Signed-off-by: Bill O'Donnell <billodo@xxxxxxxxxx>


> +STATIC ssize_t
> +xfs_stats_store(
> +     struct kobject          *kobject,
> +     struct attribute        *attr,
> +     const char              *buf,
> +     size_t                  count)

still have some spaces after the types, before the vars...

Otherwise, this looks good to me; it's not the only place we have
missing tabs... *shrug* you could resend, or maybe Dave's willing
to fix up on commit.

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Thanks,
-Eric

<Prev in Thread] Current Thread [Next in Thread>