Re: [PATCH 2/3] xfs: create symlink proc/fs/xfs/stat to sys/fs/xfs/stats

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

On 9/3/15 11:36 AM, billodo wrote:
> As a part of the work to move xfs global stats from procfs to sysfs,
> this patch creates the symlink from proc/fs/xfs/stat to sys/fs/xfs/stats.
> 
> Signed-off-by: Bill O'Donnell <billodo@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_stats.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/xfs_stats.c b/fs/xfs/xfs_stats.c
> index 856cf57..ad435f1 100644
> --- a/fs/xfs/xfs_stats.c
> +++ b/fs/xfs/xfs_stats.c
> @@ -244,9 +244,13 @@ xfs_init_procfs(void)
>       if (!proc_mkdir("fs/xfs", NULL))
>               goto out;
>  
> -     if (!proc_create("fs/xfs/stat", 0, NULL,
> -                      &xfs_stat_proc_fops))
> +     if (!proc_symlink("fs/xfs/stat", NULL,
> +                       "/sys/fs/xfs/stats/stats"))
> +     {
> +             printk(KERN_INFO "failed to created fs/xfs/stat symlink\n");
>               goto out_remove_xfs_dir;
> +     }
> +

I'm not sure we need the printk, we didn't say anything if 
proc_create(fs/xfs/stat) failed...

I guess the cleanup is fine as it is, right, it can remove a symlink too AFAIK.

-Eric


>  #ifdef CONFIG_XFS_QUOTA
>       if (!proc_create("fs/xfs/xqmstat", 0, NULL,
>                        &xqmstat_proc_fops))
>