xfs
[Top] [All Lists]

Re: xfs corruption

To: Danny Shavit <danny@xxxxxxxxxxxxxxxxx>
Subject: Re: xfs corruption
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 3 Sep 2015 11:14:39 -0500
Cc: Alex Lyakas <alex@xxxxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <55E85F5F.6010005@xxxxxxxxxxx>
References: <CAC=x_0hAQR9Ynmnqohv1R8xv3TBot5wmn7DODx6GbKU7tYv2sA@xxxxxxxxxxxxxx> <55E8498F.8090508@xxxxxxxxxxx> <CAC=x_0iUc2VEfW9qChuvUpDk5Kz=wvRGH-1w6sS0XP6CG_ERBQ@xxxxxxxxxxxxxx> <55E85F5F.6010005@xxxxxxxxxxx>
On 9/3/15 9:55 AM, Eric Sandeen wrote:
> On 9/3/15 9:26 AM, Danny Shavit wrote:

...

>> We are using modified xfs. Mainly, added some reporting features and
>> changed discard operation to be aligned with chunk sizes used in our
>> systems. The modified code resides at  https://github.com/zadarastora
>> <https://github.com/zadarastorage/zadara-xfs-pushback>ge/zadara-xfs-pushback
>> <https://github.com/zadarastorage/zadara-xfs-pushback>.
> 
> Interesting, thanks for the pointer.  I guess at this point I have to
> ask, do you see these same problems without your modifications?

Have you ever mounted this filesystem on non-zadara kernels?

looking at
https://github.com/zadarastorage/zadara-xfs-pushback/commit/094df949fd080ede546bb7518405ab873a444823

you've changed the disk format w/o adding a feature flag,
which is pretty dangerous.

-Eric

<Prev in Thread] Current Thread [Next in Thread>