| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: add ->pfn_mkwrite support for DAX |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Thu, 3 Sep 2015 07:34:37 +1000 |
| Cc: | xfs@xxxxxxxxxxx, boaz@xxxxxxxxxxxxx, kirill.shutemov@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20150902051217.GA18906@xxxxxxxxxxxxx> |
| References: | <1441157100-1658-1-git-send-email-david@xxxxxxxxxxxxx> <20150902051217.GA18906@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Sep 01, 2015 at 10:12:17PM -0700, Christoph Hellwig wrote: > On Wed, Sep 02, 2015 at 11:25:00AM +1000, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > ->pfn_mkwrite support is needed so that when a page with allocated > > backing store first takes a write fault the timestamps on the > > file are updated. THis fixes a generic/080 failure. > > Shouldn't you be able to drop the call to xfs_filemap_page_mkwrite from > xfs_filemap_fault now? No idea. It hasn't been removed from dax_fault, so I'm not going to remove it from xfs_filemap_page_mkwrite()... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [RESEND PATCH] xfsrestore: fix fs uuid order check for incremental restores, Rich Johnston |
|---|---|
| Next by Date: | XFS and nobarriers on Intel SSD, Richard Bade |
| Previous by Thread: | Re: [PATCH] xfs: add ->pfn_mkwrite support for DAX, Christoph Hellwig |
| Next by Thread: | Re: [PATCH] xfs: add ->pfn_mkwrite support for DAX, Boaz Harrosh |
| Indexes: | [Date] [Thread] [Top] [All Lists] |