xfs
[Top] [All Lists]

Re: [PATCH v2] xfsprogs: add nftw64 translation for OS X

To: Jan Tulak <jtulak@xxxxxxxxxx>
Subject: Re: [PATCH v2] xfsprogs: add nftw64 translation for OS X
From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Date: Tue, 1 Sep 2015 09:31:20 -0700
Cc: xfs@xxxxxxxxxxx, hch@xxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1441094672-18368-1-git-send-email-jtulak@xxxxxxxxxx>
References: <20150831185944.GI349@xxxxxxxxxxxxx> <1441094672-18368-1-git-send-email-jtulak@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Sep 01, 2015 at 10:04:32AM +0200, Jan Tulak wrote:
> UPDATE: changed to #define
> 
> OS X has only nftw variant - not the 64 suffix used in xfs.
> 
> Signed-off-by: Jan Tulak <jtulak@xxxxxxxxxx>
> ---
>  include/darwin.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/darwin.h b/include/darwin.h
> index 72d9c1d..f0f05b3 100644
> --- a/include/darwin.h
> +++ b/include/darwin.h
> @@ -157,6 +157,8 @@ typedef int64_t           xfs_daddr_t;
>  
>  #define HAVE_FID     1
>  
> +#define nftw64 nftw
> +

Sorry for chiming in late, but there's only one caller of nftw64 and several
callers of nftw; why not just change it to use nftw?

<shrug> There could be other reasons why xfs_estimate requires the -64
variant, but I don't know. :)

--D

>  static __inline__ int
>  platform_discard_blocks(int fd, uint64_t start, uint64_t len)
>  {
> -- 
> 2.4.3
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>