xfs
[Top] [All Lists]

Re: [PATCH 0/2] xfsdump: fix problems in cb_add_inogrp

To: Eric Sandeen <sandeen@xxxxxxxxxxx>, <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH 0/2] xfsdump: fix problems in cb_add_inogrp
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Wed, 26 Aug 2015 09:33:54 -0500
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <55D785E7.8050503@xxxxxxxxxxx>
References: <20150821193047.661578219@xxxxxxxxxxxxxxxxxxxxxxx> <55D747FE.4070401@xxxxxxxxxxx> <55D7854A.9030706@xxxxxxx> <55D785E7.8050503@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
On 08/21/2015 03:11 PM, Eric Sandeen wrote:
On 8/21/15 3:08 PM, Rich Johnston wrote:
On 08/21/2015 10:47 AM, Eric Sandeen wrote:
Hi -

Are there any testcases for these?  xfsdump is alien code, I swear;
I'm not quite sure offhand how to tickle any of these bugs.

Thanks,
-Eric


Hey Eric,

Many thanks for taking the time to review these patches.
I take a look at all your responses and get a V2 out early next week.

Sounds good.  If I was off track about the need for the extra 64-bit vars,
just educate me.  ;)

-Eric

Ok you convinced me, there is no need for patch 1 and patch 2 can be
solved by removing the local variable oldsize.

A new patch has been submitted.
[PATCH] xfsdump: prevent segfault in cb_add_inogrp

<Prev in Thread] Current Thread [Next in Thread>