Re: [PATCH] xfs_repair: set args.geo in longform_dir2_entry_check_data

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

On 8/25/15 1:34 PM, Eric Sandeen wrote:
> Here's another one where we miss setting da_args->geo:
> 
> longform_dir2_entry_check_data
>         struct xfs_da_args      da = {
>                 .dp = ip,
>               // .geo is unset
>         };
> ...
>       libxfs_dir2_data_make_free(&da ...)
>               xfs_dir2_data_make_free
>                       endptr = (char *)hdr + args->geo->blksize;
>                               BOOM
> 
> Addresses-Coverity-Id: 1298008
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> Have to wonder if there are more of these :(

Spot-checking in userspace wasn't hard; doesn't look like there are any more.

kernelspace looks ok too.

-Eric