| To: | xfs-oss <xfs@xxxxxxxxxxx> |
|---|---|
| Subject: | [PATCH] xfs_repair: set args.geo in longform_dir2_entry_check_data |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Tue, 25 Aug 2015 13:34:21 -0500 |
| Delivered-to: | xfs@xxxxxxxxxxx |
Here's another one where we miss setting da_args->geo:
longform_dir2_entry_check_data
struct xfs_da_args da = {
.dp = ip,
// .geo is unset
};
...
libxfs_dir2_data_make_free(&da ...)
xfs_dir2_data_make_free
endptr = (char *)hdr + args->geo->blksize;
BOOM
Addresses-Coverity-Id: 1298008
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---
Have to wonder if there are more of these :(
diff --git a/repair/phase6.c b/repair/phase6.c
index 04638c2..951587e 100644
--- a/repair/phase6.c
+++ b/repair/phase6.c
@@ -1506,6 +1506,7 @@ longform_dir2_entry_check_data(
int wantmagic;
struct xfs_da_args da = {
.dp = ip,
+ .geo = mp->m_dir_geo,
};
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Cant mount xfs lvm. Experimental Features?, Eric Sandeen |
|---|---|
| Next by Date: | Re: Cant mount xfs lvm. Experimental Features?, Marko Weber|8000 |
| Previous by Thread: | Re: [PATCH] xfs_repair: set args.geo in dir2_kill_block, Eric Sandeen |
| Next by Thread: | Re: [PATCH] xfs_repair: set args.geo in longform_dir2_entry_check_data, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |