xfs
[Top] [All Lists]

Re: [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inode

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inodes
From: Eryu Guan <eguan@xxxxxxxxxx>
Date: Sat, 22 Aug 2015 12:46:09 +0800
Cc: Jens Axboe <axboe@xxxxxxxxx>, Jan Kara <jack@xxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, axboe@xxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, Jan Kara <jack@xxxxxxxx>, Tejun Heo <tj@xxxxxxxxxx>, kernel-team@xxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150822003025.GS3902@dastard>
References: <20150813004435.GN3902@dastard> <20150813224415.GG4496@xxxxxxxxxxxxxxx> <20150814111408.GB8710@xxxxxxxxxxxxx> <20150817200254.GG21075@xxxxxxxxxxxxxxx> <20150818091603.GA12317@xxxxxxxxxxxxx> <20150818174718.GA15739@xxxxxxxxxxxxxxx> <20150818195439.GB15739@xxxxxxxxxxxxxxx> <20150818215611.GD3902@dastard> <20150821102053.GL17933@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20150822003025.GS3902@dastard>
User-agent: Mutt/1.5.23 (2014-03-12)
On Sat, Aug 22, 2015 at 10:30:25AM +1000, Dave Chinner wrote:
> On Fri, Aug 21, 2015 at 06:20:53PM +0800, Eryu Guan wrote:
[snip]
> 
> Eryu, can you try again, this time manually specifying the writeback
> tracepoints so you exclude the really noisy ones? You can also drop
> the xfs_file_buffered_write and xfs_file_fsync tracepoints as well,
> as we can see that the incoming side of the code is doing the right
> thing....

I excluded the writeback tracepoints you mentioned

writeback_mark_inode_dirty
writeback_dirty_inode_start
writeback_dirty_inode
writeback_dirty_page
writeback_write_inode

and left all other writeback tracepoints enabled, also dropped
xfs_file_buffered_write and xfs_file_fsync.

This time I can reproduce generic/048 quickly and please download the
trace info from below

http://128.199.137.77/writeback-v2/

Thanks,
Eryu

<Prev in Thread] Current Thread [Next in Thread>