| To: | rjohnston@xxxxxxx, xfs@xxxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH 0/2] xfsdump: fix problems in cb_add_inogrp |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Fri, 21 Aug 2015 10:47:10 -0500 |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20150821193047.661578219@xxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20150821193047.661578219@xxxxxxxxxxxxxxxxxxxxxxx> |
On 8/21/15 9:01 AM, rjohnston@xxxxxxx wrote: > The memset in cb_add_inogrp will segfault when the index oldsize > overflows. In cb_add_inogrp(), the temp variables used in > calculating the new i2gmap segment offset should be int64 instead > of intgen_t (int32). > > A second bug also occurs because we already compensate for the > length of each item in oldsize so are 32bit wrap becomes a 40bit > wrap. Hi - Are there any testcases for these? xfsdump is alien code, I swear; I'm not quite sure offhand how to tickle any of these bugs. Thanks, -Eric |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | High quality Bluetooth products, Frank |
|---|---|
| Next by Date: | Re: [PATCH 0/2] xfsdump: fix problems in cb_add_inogrp, Rich Johnston |
| Previous by Thread: | Re: [PATCH 2/2] xfsdump: don't do pointer math twice, Eric Sandeen |
| Next by Thread: | Re: [PATCH 0/2] xfsdump: fix problems in cb_add_inogrp, Rich Johnston |
| Indexes: | [Date] [Thread] [Top] [All Lists] |