xfs
[Top] [All Lists]

Re: [PATCH 11/11] xfsprogs: Add a way to compile without blkid

To: Jan Tulak <jtulak@xxxxxxxxxx>
Subject: Re: [PATCH 11/11] xfsprogs: Add a way to compile without blkid
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 17 Aug 2015 12:39:13 -0700
Cc: xfs@xxxxxxxxxxx, hch@xxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1439828606-7886-12-git-send-email-jtulak@xxxxxxxxxx>
References: <1439828606-7886-1-git-send-email-jtulak@xxxxxxxxxx> <1439828606-7886-12-git-send-email-jtulak@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Mon, Aug 17, 2015 at 06:23:26PM +0200, Jan Tulak wrote:
> UPDATE: default to "signature found", so without blkid is
>         -f mandatory.

Belongs in the cover letter, not this patch.

>               } else
>                       ft->psectorsize = ft->lsectorsize = BBSIZE;
>       } else {
> +#ifdef ENABLE_BLKID
>               blkid_get_topology(dfile, &ft->dsunit, &ft->dswidth,
>                                  &ft->lsectorsize, &ft->psectorsize,
>                                  force_overwrite);
> +#endif /* ENABLE_BLKID */
>       }
>  
>       if (xi->rtname && !xi->risfile) {
>               int sunit, lsectorsize, psectorsize;
>  
> +#ifdef ENABLE_BLKID
>               blkid_get_topology(xi->rtname, &sunit, &ft->rtswidth,
>                                  &lsectorsize, &psectorsize, force_overwrite);
> +#endif /* ENABLE_BLKID */

I think you need to proide a dummy blkid_get_topology which at least
sets the two sector sizes to 512.

<Prev in Thread] Current Thread [Next in Thread>