Re: [PATCH v4 09/11] xfsprogs: Add mntent.h check into autoconf

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH v4 09/11] xfsprogs: Add mntent.h check into autoconf
From:	Jan Tulak <jtulak@xxxxxxxxxx>
Date:	Mon, 17 Aug 2015 17:15:12 +0200
Cc:	xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20150817150401.GA29056@xxxxxxxxxxxxx>
References:	<20150804112153.GG18906@xxxxxxxxxxxxx> <1439823687-7279-1-git-send-email-jtulak@xxxxxxxxxx> <20150817150401.GA29056@xxxxxxxxxxxxx>

On Mon, Aug 17, 2015 at 5:04 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

This looks mostly fine.Â I think you could just add the
AC_CHECK_HEADERS directly to configure.ac, but otherwise it's exactly
what I though.

In configure.ac, there are no direct checks for headers, just calls of all the various

AC_HAVE_*. I'm not sure it is a good idea to mix now. Unless you think that all

the functions should be moved into configure.ac from the m4/ directory.

Can you please resend all your pending patches in a single series,
and move the UPDATES: lines and other internal changelogs to the
cover letter instead of the patch descriptions?

Thanks for doing this work!

Sure, I'll send it again as a whole. And np. :-)

Jan Tulak

jtulak@xxxxxxxxxx

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH v3 07/11] xfsprogs: missing and dummy calls for OS X support, (continued) [PATCH v3 07/11] xfsprogs: missing and dummy calls for OS X support, Jan Tulak [PATCH v3 08/11] xfsprogs: Add fls check into autoconf, Jan Tulak Re: [PATCH v3 08/11] xfsprogs: Add fls check into autoconf, Christoph Hellwig Re: [PATCH v3 08/11] xfsprogs: Add fls check into autoconf, Jan Tulak Re: [PATCH v3 08/11] xfsprogs: Add fls check into autoconf, Jan Tulak [PATCH v4 03/11] xfsprogs: Add fls check into autoconf, Jan Tulak [PATCH v3 09/11] xfsprogs: Add mntent.h check into autoconf, Jan Tulak Re: [PATCH v3 09/11] xfsprogs: Add mntent.h check into autoconf, Christoph Hellwig [PATCH v4 09/11] xfsprogs: Add mntent.h check into autoconf, Jan Tulak Re: [PATCH v4 09/11] xfsprogs: Add mntent.h check into autoconf, Christoph Hellwig Re: [PATCH v4 09/11] xfsprogs: Add mntent.h check into autoconf, Jan Tulak <= [PATCH v3 10/11] xfsprogs: replace obsolete memalign with posix_memalign, Jan Tulak Re: [PATCH v3 10/11] xfsprogs: replace obsolete memalign with posix_memalign, Dave Chinner [PATCH 10/11] xfsprogs: replace obsolete memalign with posix_memalign, Jan Tulak [PATCH v2 11/11] xfsprogs: Prefix LIST_... macros to XFS_LIST_..., Jan Tulak [PATCH v4 11/11] xfsprogs: prevent LIST_ macros conflicts, Jan Tulak Re: [PATCH v4 11/11] xfsprogs: prevent LIST_ macros conflicts, Christoph Hellwig

Previous by Date:	Re: [PATCH v4 09/11] xfsprogs: Add mntent.h check into autoconf, Christoph Hellwig
Next by Date:	[PATCH 00/11] xfsprogs: Partial OS X support, Jan Tulak
Previous by Thread:	Re: [PATCH v4 09/11] xfsprogs: Add mntent.h check into autoconf, Christoph Hellwig
Next by Thread:	[PATCH v3 10/11] xfsprogs: replace obsolete memalign with posix_memalign, Jan Tulak
Indexes:	[Date] [Thread] [Top] [All Lists]