xfs
[Top] [All Lists]

Re: generic/04[89] fail on XFS due to change in writeback code [4.2-rc1

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: generic/04[89] fail on XFS due to change in writeback code [4.2-rc1 regression]
From: Tejun Heo <tj@xxxxxxxxxx>
Date: Thu, 13 Aug 2015 15:16:02 -0400
Cc: Eryu Guan <eguan@xxxxxxxxxx>, xfs@xxxxxxxxxxx, axboe@xxxxxx, jack@xxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=oEPonsmDgG8sI3WMPqbD2w010CnouYgxNcLWuKjCgbg=; b=JfY/iN/QR8MhHQXsxBqveMXlCB+c6dyyiMSHt9Q+iFm475ssXBMG38hlYwzYVjpoJE uUPR81jHLQ6sYLr5G1dAIYCILv0TyR1nvsS8TltzfNrTAo6bXl7ddKow1uWa3XV2a1At uow9m4tthbsas6cXWAL6k0Z/3lXEWCk4Hi0eeDPK4Yxa352/X4/Kcn0Qr64m2eCRKiBk 2OpkM2LIEIdYpl3UhQ0RqYjw+MaBPxUPk7fqJpdC5iy80EzCQ6fhMOIhq+ZS766kyAsB 4t6GOe2zhHGUBjWvcSmu72BXtg9Us5WwMUkm5VCJ41fMoKEeMHz+OiLtkCZJub3NUj70 q8sg==
In-reply-to: <20150813153442.GE4496@xxxxxxxxxxxxxxx>
References: <20150812101204.GE17933@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20150813004435.GN3902@dastard> <20150813153442.GE4496@xxxxxxxxxxxxxxx>
Sender: Tejun Heo <htejun@xxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Thu, Aug 13, 2015 at 11:34:42AM -0400, Tejun Heo wrote:
> On Thu, Aug 13, 2015 at 10:44:35AM +1000, Dave Chinner wrote:
> > It might be a couple of days before I really get a chance to dig
> > into this, so it might be best if Tejun can look into it first.
> 
> Yeap, have been looking into it since yesterday.  I have some
> suspicions.  I'll write once I know more.

So, here are what I've found out till now.

* I can't reproduce it for some reason.

* There's a bug in b_dirty_time handling.  sync_inodes_sb() should
  schedule writebacks regardless of b_dirty_time but it currently
  isn't.  I'm working on a patch to fix it.

* But I can't see how the above bug would lead to failure of size
  sync.  One possibility is that wb_has_dirty_io() and/or
  bdi_has_dirty_io() is getting out of sync for some reason.  I'll
  write up a debug patch for this.

Thanks.

-- 
tejun

<Prev in Thread] Current Thread [Next in Thread>