Re: [PATCH] libxfs: readahead of dir3 data blocks should use the read ve

xfs

Re: [PATCH] libxfs: readahead of dir3 data blocks should use the read ve

To:	"Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject:	Re: [PATCH] libxfs: readahead of dir3 data blocks should use the read verifier
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 12 Aug 2015 00:28:34 -0700
Cc:	Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20150811235038.GL10043@xxxxxxxxxxxxxxxx>
References:	<20150811235038.GL10043@xxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.23 (2014-03-12)

On Tue, Aug 11, 2015 at 04:50:38PM -0700, Darrick J. Wong wrote:
> In the dir3 data block readahead function, use the regular read
> verifier to check the block's CRC and spot-check the block contents
> instead of directly calling only the spot-checking routine.  This
> prevents corrupted directory data blocks from being read into the
> kernel, which can lead to garbage ls output and directory loops (if
> say one of the entries contains slashes and other junk).
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] libxfs: readahead of dir3 data blocks should use the read verifier, Darrick J. Wong Re: [PATCH] libxfs: readahead of dir3 data blocks should use the read verifier, Christoph Hellwig <=

Previous by Date:	Re: [PATCH 3/8] xfs: remove nonblocking mode from xfs_vm_writepage, Christoph Hellwig
Next by Date:	generic/04[89] fail on XFS due to change in writeback code, Eryu Guan
Previous by Thread:	[PATCH] libxfs: readahead of dir3 data blocks should use the read verifier, Darrick J. Wong
Next by Thread:	Re: PROBLEM: XFS on ARM corruption 'Structure needs cleaning', katsuki.uwatoko
Indexes:	[Date] [Thread] [Top] [All Lists]