| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 06/11] xfs: don't leave EFIs on AIL on mount failure |
| From: | Brian Foster <bfoster@xxxxxxxxxx> |
| Date: | Mon, 10 Aug 2015 08:38:54 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20150809080150.GA4253@xxxxxxxxxxxxx> |
| References: | <1438883072-28706-1-git-send-email-bfoster@xxxxxxxxxx> <1438883072-28706-7-git-send-email-bfoster@xxxxxxxxxx> <20150809080150.GA4253@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
On Sun, Aug 09, 2015 at 01:01:50AM -0700, Christoph Hellwig wrote: > > STATIC int > > xlog_recover_process_efis( > > - struct xlog *log) > > + struct xlog *log, > > + bool cancel) > > There is almost no code shared between cancelation and processing, > so please add a new xlog_cancel_efis helper instead. > See v2. > > + efip = (struct xfs_efi_log_item *) lip; > > Please use container_of to get to a containing structure. > Ok. Brian > _______________________________________________ > xfs mailing list > xfs@xxxxxxxxxxx > http://oss.sgi.com/mailman/listinfo/xfs |
| Previous by Date: | Re: [PATCH 04/11] xfs: ensure EFD trans aborts on log recovery extent free failure, Brian Foster |
|---|---|
| Next by Date: | Re: [PATCH 04/11] xfs: ensure EFD trans aborts on log recovery extent free failure, Brian Foster |
| Previous by Thread: | Re: [PATCH 06/11] xfs: don't leave EFIs on AIL on mount failure, Christoph Hellwig |
| Next by Thread: | [PATCH 04/11] xfs: ensure EFD trans aborts on log recovery extent free failure, Brian Foster |
| Indexes: | [Date] [Thread] [Top] [All Lists] |