Re: [PATCH 05/11] xfs: use EFI refcount consistently in log recovery

To:	Brian Foster <bfoster@xxxxxxxxxx>
Subject:	Re: [PATCH 05/11] xfs: use EFI refcount consistently in log recovery
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Sun, 9 Aug 2015 00:56:40 -0700
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1438883072-28706-6-git-send-email-bfoster@xxxxxxxxxx>
References:	<1438883072-28706-1-git-send-email-bfoster@xxxxxxxxxx> <1438883072-28706-6-git-send-email-bfoster@xxxxxxxxxx>
User-agent:	Mutt/1.5.23 (2014-03-12)

> +     error = xfs_efi_copy_format(&(item->ri_buf[0]), &(efip->efi_format));
> +     if (error) {
>               xfs_efi_item_free(efip);

Shou;dn't we switch all users of xfs_item_free except for
xfs_efi_release to xfs_efi_release now for consistency?

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/11] xfs: miscellaneous logging, recovery, umount fixes, Brian Foster [PATCH 07/11] xfs: icreate log item recovery and cancellation tracepoints, Brian Foster Re: [PATCH 07/11] xfs: icreate log item recovery and cancellation tracepoints, Christoph Hellwig [PATCH 08/11] xfs: fix broken icreate log item cancellation, Brian Foster [PATCH 05/11] xfs: use EFI refcount consistently in log recovery, Brian Foster Re: [PATCH 05/11] xfs: use EFI refcount consistently in log recovery, Dave Chinner Re: [PATCH 05/11] xfs: use EFI refcount consistently in log recovery, Brian Foster Re: [PATCH 05/11] xfs: use EFI refcount consistently in log recovery, Christoph Hellwig <= Re: [PATCH 05/11] xfs: use EFI refcount consistently in log recovery, Brian Foster [PATCH 02/11] xfs: return committed status from xfs_trans_roll(), Brian Foster Re: [PATCH 02/11] xfs: return committed status from xfs_trans_roll(), Christoph Hellwig [PATCH 01/11] xfs: disentagle EFI release from the extent count, Brian Foster Re: [PATCH 01/11] xfs: disentagle EFI release from the extent count, Christoph Hellwig Re: [PATCH 01/11] xfs: disentagle EFI release from the extent count, Brian Foster Re: [PATCH 01/11] xfs: disentagle EFI release from the extent count, Christoph Hellwig Re: [PATCH 01/11] xfs: disentagle EFI release from the extent count, Brian Foster [PATCH 10/11] xfs: clean up root inode properly on mount failure, Brian Foster Re: [PATCH 10/11] xfs: clean up root inode properly on mount failure, Christoph Hellwig

Previous by Date:	Re: [PATCH 04/11] xfs: ensure EFD trans aborts on log recovery extent free failure, Christoph Hellwig
Next by Date:	Re: [PATCH 06/11] xfs: don't leave EFIs on AIL on mount failure, Christoph Hellwig
Previous by Thread:	Re: [PATCH 05/11] xfs: use EFI refcount consistently in log recovery, Brian Foster
Next by Thread:	Re: [PATCH 05/11] xfs: use EFI refcount consistently in log recovery, Brian Foster
Indexes:	[Date] [Thread] [Top] [All Lists]